Check for remote url instead of .git existence #2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation of .git checking have some issues: - If a kernel source being cloned using git-repo tool, especially newer version, it will clone .git in .repo inside of the submodule source. - Newer kernel source changed how $(src) & $(srctree) output. In the case of kernel 6.11 as I tested $(src) show the relative path of the symlink in drivers/ instead of KernelSU main directory. Which makes checking for ../.git existence comletely useless. One idea I would like to propose is to check for the remote URL in $(src). If the remote is correct then we can assume this is KSU repo and then count the version (also unshallow the repo). Here's what I did: - Check if kernel is 6.9+ and then change $(src) accordingly. - Print $(src) remote in verbose and check for the correct URL (both ssh & https). - If correct, check if the repo is shallow by using git rev-parse --is-shallow-repository. Unshallow if it's return true. - Calculate version as usual. The only drawback I can see so far is that forks will have to edit the url in the Makefile, which I don't think it's much of an issue. Signed-off-by: hmtheboy154 <[email protected]>
hmtheboy154
force-pushed
the
makefile_git
branch
from
5d88940 to
e907213
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of .git checking have some issues:
$(src)&$(srctree)output. In the case of kernel 6.11 as I tested$(src)show the relative path of the symlink in drivers/ instead of KernelSU main directory. Which makes checking for ../.git existence completely useless.One idea I would like to propose is to check for the remote URL in
$(src). If the remote is correct then we can assume this is KSU repo and then count the version (also unshallow the repo). Here's what I did:$(src)accordingly.$(src)remote in verbose and check for the correct URL (both ssh & https).git rev-parse --is-shallow-repository. Unshallow if it's return true.The only drawback I can see so far is that forks will have to edit the url in the Makefile, which I don't think it's much of an issue.